Bill XIE has uploaded this change for review. ( https://review.coreboot.org/21673
Change subject: device/dram/ddr2.c: fix a minor regression introduced earlier ......................................................................
device/dram/ddr2.c: fix a minor regression introduced earlier
A regression is hidden in Change I091121a5d08159cea4befdedb5f3a92ce132c6e5, which breaks the build procedure when CONFIG_DEBUG_RAM_SETUP is set.
Maybe it had better implement "printram" and the like as inline functions instead of macros.
Change-Id: If956435bd0c39b1f3e722c2cfc48d2d0f35abc9b Signed-off-by: Bill XIE persmule@gmail.com --- M src/device/dram/ddr2.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/21673/1
diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index d524238..e06e342 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -547,7 +547,7 @@ ret = SPD_STATUS_INVALID_FIELD; dimm->flags.self_refresh = (spd[12] >> 7) & 1; printram("The assembly supports self refresh: %s\n", - dimm->flags.self_refresh ? "true", "false"); + dimm->flags.self_refresh ? "true" : "false");
/* Number of PLLs on DIMM */ if (dimm->rev >= 0x11)