Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40306 )
Change subject: drivers/ipmi: Add IPMI read FRU chassis info area ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c... PS8, Line 96: /* Read data string from data_ptr and store it to string, return the
please follow code comment style from https://www.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c... PS8, Line 123: void
there are a bunch of errors this function detect. […]
I uploaded a patchset for this function, after it's reviewed ok I will modify similar changes to read_fru_board_info_area and read_fru_product_info_area as well.
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c... PS8, Line 131: if (!offset) : return;
not: may be move this upper?
Done