Attention is currently required from: Kevin Chang, Kane Chen, Paul Menzel, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62919 )
Change subject: mb/google/brya/var/taeko: Disable GL9763e PCIE port L0s
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62919/comment/df6f1bef_195438f5
PS2, Line 635: s_cfg->PcieRpAspm[i] = config->pcierpaspm[i];
by doing this, all projects without devicetree settings , PcieRpAspm will be 0.
also , i don't understand why you need to control aspm on root port side.
have you checked ASPM is working in OS?
you should compare lspci -vvv on pcie device and root port
I agree with Kane
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19b5f3dc8d95e153301d777492c921ce582ba988
Gerrit-Change-Number: 62919
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Mon, 21 Mar 2022 05:17:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-MessageType: comment