Attention is currently required from: Felix Singer, Paul Menzel, YH Lin.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60077 )
Change subject: mb/google/brya/var/taniks: Configure DRIVER_TPM_I2C_BUS
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60077/comment/c1ffe972_be7589cd
PS2, Line 7: for taniks
Remove, as it’s already part of the prefix?
Done
https://review.coreboot.org/c/coreboot/+/60077/comment/c1d9554e_54bb4bee
PS2, Line 9: address
nit: remove this word, the I2C address is specified in devicetree, this is just which I2C bus to use […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
Gerrit-Change-Number: 60077
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Tue, 14 Dec 2021 00:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment