Attention is currently required from: Tim Wawrzynczak. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63561 )
Change subject: drivers/i2c/dw_i2c: Adjust to handle 0-byte transfers ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/63561/comment/fa5a3715_c6f271e8 PS1, Line 431: if (segments->len != 0)
I think it's OK to still print the message in the 0-byte write case
I did that so that there weren't a bunch of spurious TX aborted msgs in cbmem. Some boards have 3-4 options each for touchpad/screen, so there can be up to 6 of them surrounding the output for the devices which are actually present
-
Matt DeVillier (Code Review)