Attention is currently required from: Felix Singer, Raul Rangel, Furquan Shaikh, Paul Menzel, Angel Pons, Patrick Rudolph, Lance Zhao, Jason Glenesk, Nico Huber, Marshall Dawson, Tim Wawrzynczak, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58118 )
Change subject: acpigen,soc/amd/cezanne,intel/{common,skl}: rework CPPC table passing ......................................................................
Patch Set 2:
(94 comments)
File src/cpu/intel/common/common_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/a742914d_5cdca1f9 PS2, Line 105: [CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/c4b7f182_173f23fe PS2, Line 105: [CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 0, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/a04258aa_5500ceed PS2, Line 106: [CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/2f9a77ad_35499712 PS2, Line 106: [CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_PLATFORM_INFO, 8, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/25dbe420_1de8af95 PS2, Line 107: [CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/d8268dcc_50aa4e72 PS2, Line 107: [CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/90a1ef6b_76512f8d PS2, Line 107: [CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 16, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/8ad56b32_4b994d8e PS2, Line 108: [CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/a9769e34_8522707b PS2, Line 108: [CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/b525373e_3b141ba6 PS2, Line 108: [CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 24, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/27b63d3b_299f60d1 PS2, Line 109: [CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/ba66d600_93387e88 PS2, Line 109: [CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_CAPABILITIES, 8, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/4596b5ee_d06fbb88 PS2, Line 110: [CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/b6d977d0_917ab765 PS2, Line 110: [CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 16, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/575ab08b_701832fb PS2, Line 111: [CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/a9551715_00217b56 PS2, Line 111: [CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 0, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/5cbcd9e0_26761eb1 PS2, Line 112: [CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/0ff18518_58db9370 PS2, Line 112: [CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 8, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/e17049bd_000cc85a PS2, Line 113: [CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/f8772ce5_030936c7 PS2, Line 113: [CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/250052ea_9c63ea1f PS2, Line 114: [CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/4a9d3190_20528934 PS2, Line 114: [CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/467a48b1_6e77a722 PS2, Line 115: [CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/07a80cab_760c6997 PS2, Line 115: [CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/e25b7022_85b0f37a PS2, Line 116: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/d789c7ad_f8f362ea PS2, Line 116: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_MPERF, 0, 64) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/c3eb236d_7b64dfe8 PS2, Line 117: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/0275e391_fb1b20e1 PS2, Line 117: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(IA32_APERF, 0, 64) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/b43e94c6_870f0e70 PS2, Line 118: [CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/8114ad6c_90f9be02 PS2, Line 118: [CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_STATUS, 2, 1) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/ccd1c4bb_00b67ce5 PS2, Line 119: [CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/4afb345a_3b1d5b26 PS2, Line 119: [CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(IA32_PM_ENABLE, 0, 1) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/d3c06abc_32bf4cef PS2, Line 123: [CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/bb938703_887b25c9 PS2, Line 123: [CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 32, 10) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/823b4626_9465fbef PS2, Line 124: [CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/49183c84_ec242de6 PS2, Line 124: [CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(IA32_HWP_REQUEST, 24, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/dfae96ca_91d1fb40 PS2, Line 125: [CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/06d9c297_bd607991 PS2, Line 125: [CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/806d1aac_902349b9 PS2, Line 128: [CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/5be18b9c_957db03f PS2, Line 128: [CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/8c3c79bf_9bd19b6f PS2, Line 129: [CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/6e22afc9_ee2c6d7b PS2, Line 129: [CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
File src/soc/amd/cezanne/cppc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/27211d05_f7bb2157 PS2, Line 15: [CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/c39a9554_ac2635ab PS2, Line 15: [CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/3fbe2ffb_5a4cff02 PS2, Line 15: [CPPC_HIGHEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_HIGHEST_PERF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/4cd37c25_9d742c98 PS2, Line 16: [CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/758fb409_fc2babdb PS2, Line 16: [CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/924d72e6_26dc7826 PS2, Line 16: [CPPC_NOMINAL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_NOMINAL_PERF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/63397322_1688d534 PS2, Line 17: [CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/cd60c10a_1913c974 PS2, Line 17: [CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/a7d79808_d838fdbe PS2, Line 17: [CPPC_LOWEST_NONL_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOW_NON_LIN_PERF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/5f6c63e4_9022bda9 PS2, Line 18: [CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/f4e996e7_c7efb26b PS2, Line 18: [CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/79e1b2a5_3652b5d7 PS2, Line 18: [CPPC_LOWEST_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_CAPABILITY_1, SHIFT_CPPC_CAPABILITY_1_LOWEST_PERF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/d034f38b_d1d302d4 PS2, Line 19: [CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/c419fb1c_da3d478a PS2, Line 19: [CPPC_GUARANTEED_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/272429da_5abbb4b3 PS2, Line 20: [CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/1b6cc06c_71316598 PS2, Line 20: [CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/963ff49d_ec2022cd PS2, Line 20: [CPPC_DESIRED_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_DES_PERF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/413a07d0_a08f1aab PS2, Line 21: [CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/2539daba_adea4839 PS2, Line 21: [CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/78960ea6_fcb41ab5 PS2, Line 21: [CPPC_MIN_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MIN_PERF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/cde5189e_a308e9cc PS2, Line 22: [CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/a7f1213d_90974f65 PS2, Line 22: [CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/2952b104_b48c2e6d PS2, Line 22: [CPPC_MAX_PERF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_MAX_PERF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/0d5228d3_43e7e632 PS2, Line 23: [CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/08f56622_536a22f8 PS2, Line 23: [CPPC_PERF_REDUCE_TOLERANCE] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/748fc11c_f91d202c PS2, Line 24: [CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/79766c77_9a2eddfc PS2, Line 24: [CPPC_TIME_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/e5616a7e_e88b5375 PS2, Line 25: [CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/47250889_60632b86 PS2, Line 25: [CPPC_COUNTER_WRAP] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/1ef51eac_5ec9718c PS2, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/d39f2b1f_f7fa5f5b PS2, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/6c7dbf1f_5f963c15 PS2, Line 26: [CPPC_REF_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_MAX_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/91740026_2f6ff0cf PS2, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/446c804e_59c0c4c8 PS2, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/5efea3f6_7c34b040 PS2, Line 27: [CPPC_DELIVERED_PERF_COUNTER] = CPPC_REG( ACPI_REG_MSR(MSR_ACTUAL_PERFORMANCE_FREQUENCY_CLOCK_COUNT, 0, 64) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/bcfb081b_b47bf18d PS2, Line 28: [CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/0528ea30_cf5404fa PS2, Line 28: [CPPC_PERF_LIMITED] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_STATUS, 1, 1) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/6c2b8e71_c1ef7740 PS2, Line 29: [CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/af594b70_4315edfa PS2, Line 29: [CPPC_ENABLE] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_ENABLE, 0, 1) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/74b7df83_9de79a66 PS2, Line 32: [CPPC_AUTO_SELECT] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/05a5e002_f8191386 PS2, Line 32: [CPPC_AUTO_SELECT] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/35dfa927_641bb0d8 PS2, Line 33: [CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/ea8b823f_f89bd099 PS2, Line 33: [CPPC_AUTO_ACTIVITY_WINDOW] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/2a9e2fd7_2bfb80f9 PS2, Line 34: [CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) ), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/128a1d16_ef09ad0b PS2, Line 34: [CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/b9c0166b_ea2eb101 PS2, Line 34: [CPPC_PERF_PREF] = CPPC_REG( ACPI_REG_MSR(MSR_CPPC_REQUEST, SHIFT_CPPC_REQUEST_ENERGY_PERF_PREF, 8) ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/2579f768_b9a9e3cb PS2, Line 35: [CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/33babcc3_921754f6 PS2, Line 35: [CPPC_REF_PERF] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/3d1c744a_42fff337 PS2, Line 38: [CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/2862b7cf_9bb329f1 PS2, Line 38: [CPPC_LOWEST_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/b5cdcd5c_e7f76355 PS2, Line 39: [CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129831): https://review.coreboot.org/c/coreboot/+/58118/comment/8559b0fa_1148f200 PS2, Line 39: [CPPC_NOMINAL_FREQ] = CPPC_REG( ACPI_REG_UNSUPPORTED ), space prohibited before that close parenthesis ')'