Attention is currently required from: Martin L Roth, Matt DeVillier, Paul Menzel.
Alper Nebi Yasak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80365?usp=email )
Change subject: mb/qemu/fw_cfg: Support using DMA to select fw_cfg file ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80365/comment/17696b7f_b9701828 : PS1, Line 11: "file"s
"file's" ?
Plural. QEMU calls them files, but I felt weird about that because it doesn't really match my intuition about what a file is, so I used quotation marks. I'll remove them if that makes things unclear.
https://review.coreboot.org/c/coreboot/+/80365/comment/c6deffdc_50cf9ff6 : PS1, Line 15: to other architectures
Only qemu-i440fx is changed though. […]
It's used for qemu-i440fx and qemu-q35 right now, but I'm trying to move the relevant files to drivers/ in CB:80368 and make it support other architectures in CB:80369.
Patchset:
PS2:
hi Alper, can you address the unresolved comments so we can get this patch merged?
Sorry about that, I got sick at the worst time, just after I sent everything. (Almost fully recovered though)