[S] Change in coreboot[main]: src/device: Add more condition to check valid PCI device id

[Subrata Banik (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Pratikkumar V Prajapati, Wonkyu Kim.

Subrata Banik has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84228?usp=email )

Change subject: src/device: Add more condition to check valid PCI device id
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84228/comment/8900ac9e_0903930b?usp... :
PS2, Line 12: Below are invalid PCI device id cases
            : VID: 0x0 or 0xffff
            : DID: 0x0 or 0xffff
> I think it does not harm to add more condition and DID 0x0 and 0xffff are not valid .

I see this as buggy hardware and FW is not the place to W/A buggy HW, you can always put a recommendation to specific team at Intel to provide proper DID/VID going forward.
> Do you have concern for performance by checking more? Or do you think DID 0x0 or 0xffff can be valid case? 
> If we're worried about performance issue, we can add Kconfig to check more like this.

This is beyond performance, we shouldn't incorporate buddy HW checks in coreboot beyond what is legit and added.