Attention is currently required from: Jérémy Compostella, Paul Menzel, Pranava Y N, Subrata Banik.
Li1 Feng has posted comments on this change by Li1 Feng. ( https://review.coreboot.org/c/coreboot/+/85464?usp=email )
Change subject: mb/google/fatcat: config GPP_F23 as ISH gpio pin
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS4:
Can we handle this using FW_CONFIG ?
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/85464/comment/505570e9_fcbfa1eb?usp... :
PS4, Line 9: The GPP_F23/ISH_GP_9A pin receives the lid open/close signal from
: SMC_LID. This pin is not utilized in the AP firmware stack; however, the
: ISH firmware requires this signal for its tablet mode support.
: Therefore, we configure this pin as an ISH GPIO.
The right side looks a little unaligned. It’d be great if you re-flowed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85464?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I19a4d6967acf96aefe2f38d628f898811d8a6e6d
Gerrit-Change-Number: 85464
Gerrit-PatchSet: 5
Gerrit-Owner: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Tue, 10 Dec 2024 17:19:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org