Attention is currently required from: Karthik Ramasubramanian, Ren Kuo, Shelley Chen, Sheng-Liang Pan.
Paul Menzel has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83779?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox/var/jubilant: Add SAR sensor SX9324 ......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83779/comment/710ed5eb_0cff71e9?usp... : PS7, Line 412: register "ph0_pin" = "{1, 2, 2}" : register "ph1_pin" = "{2, 1, 2}" : register "ph2_pin" = "{2, 2, 1}" : register "ph3_pin" = "{2, 1, 1}" : register "ph01_resolution" = "1024" : register "ph23_resolution" = "1024" : register "startup_sensor" = "1" : register "ph01_proxraw_strength" = "2" : register "ph23_proxraw_strength" = "2" : register "avg_pos_strength" = "256" : register "cs_idle_sleep" = ""hi-z"" : register "int_comp_resistor" = ""lowest"" : register "input_precharge_resistor_ohms" = "4000" : register "input_analog_gain" = "1" : device i2c 28 on : probe DB_USB DB_1A_LTE : end Please document the source for these values in the commit message.