Attention is currently required from: Angel Pons.
Nicholas Sudsgaard has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80411?usp=email )
Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M710s ......................................................................
Patch Set 17:
(2 comments)
File Documentation/mainboard/lenovo/thinkcentre_m710s.md:
https://review.coreboot.org/c/coreboot/+/80411/comment/7dd93d91_231c75a4?usp... : PS17, Line 5: that even dummies could follow through
I would prefer to avoid such expressions. […]
Thanks for the detailed review!
I agree that most of this documentation doesn't belong here, I'll get rid of everything except the mainboard specific stuff. Also, I think most of your questions would be answered by the fact that I had little idea what I was doing.
Sorry for the late reply I've been a bit busy. :P
https://review.coreboot.org/c/coreboot/+/80411/comment/b363027d_30b96513?usp... : PS17, Line 148: 'W25Q64BV/W25Q64CV/W25Q64FV'
Earlier you stated that the chip is a `W25Q64JV`. […]
I don't think flashrom has support for `W25Q64JV` specifically (at least when I wrote the documentation). When I looked at the datasheet back then, I think it was very similar to `W25Q64BV/W25Q64CV/W25Q64FV`, so I just used it instead (I haven't had an issues with it).
Thinking about it now I should probably look into it a little further.