Attention is currently required from: Raul Rangel, Rob Barnes, Yu-hsuan Hsu, Gwendal Grignou.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57699 )
Change subject: mb/google/guybrush: Present SX9324 on guybrush
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57699/comment/e0cc691b_c0a5030e
PS1, Line 140: device
Removing this will cause no audio on proto 0. […]
I think on Proto 0, the only way to enable Audio was to unstuff the SAR sensor. Any time the SAR sensor was stuffed, probing the speaker amplifier failed and audio did not function. So I think we could not help much on Proto 0.
Why do we need to modify the kernel driver on Proto 1 and Proto 2. I can see that the UID and HID has not changed. Also the i2c address has not changed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I024fbcd32acf54a57b43713864b860c5e4660295
Gerrit-Change-Number: 57699
Gerrit-PatchSet: 2
Gerrit-Owner: Gwendal Grignou
gwendal@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Attention: Gwendal Grignou
gwendal@chromium.org
Gerrit-Comment-Date: Tue, 28 Sep 2021 04:46:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Yu-hsuan Hsu
yuhsuan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment