Attention is currently required from: Ana Carolina Cabral.
Paul Menzel has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84776?usp=email )
Change subject: mb/amd/common: Add common directory ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84776/comment/d21564e4_91878994?usp... : PS3, Line 7: Add common directory : Maybe:
Add common NOVA daughter board detection
File src/mainboard/amd/common/nova/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/84776/comment/d0d470b9_2fef8118?usp... : PS3, Line 6:
Just one blank line please
I meant no blank lines at the end of files please.
File src/mainboard/amd/common/nova/nova_card.c:
https://review.coreboot.org/c/coreboot/+/84776/comment/1de51e53_374e719c?usp... : PS3, Line 25: uint16_t connector_type = data[1] | data[0] << 8;
`code indent should use tabs where possible`
Please fix.