Attention is currently required from: David Wu, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee. Alan Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Configure the ISOLATE pin of LAN ......................................................................
Patch Set 9:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58105/comment/a7605d09_c85cef4e PS6, Line 7: Configurate
Configure
Done
https://review.coreboot.org/c/coreboot/+/58105/comment/88cfaf68_ca17e6d5 PS6, Line 9: Copy the default configuration from Puff. : Update the 'stop_gpio' to GPP_H22. : Remove 'wake'. ("WAKE#" is not a GPIO pin.)
Please format this as a list.
Done
https://review.coreboot.org/c/coreboot/+/58105/comment/003eda4d_58806779 PS6, Line 15: Build Pass
Maybe note down the command.
Done
https://review.coreboot.org/c/coreboot/+/58105/comment/5ba1ee28_ed961077 PS6, Line 15: Pass
pass
Done
Patchset:
PS9: Don't know why it is still 'Merge Conflict'. I have done git pull, git rebase and git push again...
File src/drivers/net/r8168.c:
PS5:
Separate to https://review.coreboot. […]
Done
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58105/comment/fd243ebf_b5dd598f PS5, Line 86: register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H22)"
So this PowerResource will look sorta like this: […]
Yes. The ISOLATE pin is active low. Tested on wake-pin reworked device and the wakeonlan function is still working.
-
Alan Huang (Code Review)