Attention is currently required from: Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63289 )
Change subject: soc/qualcomm/common: Add strict flag to clock_configure() ......................................................................
Patch Set 5:
(1 comment)
File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/63289/comment/a38ed2f8_a2739fbd PS4, Line 218: &mdss_clk_cfg, 0, 0, false);
nit: looking at how this works (which is a little haphazard anyway... […]
I think that if it's the case that we're going to universally look for exact matches, then we should actually change the common/clock.c comparison to be == instead at https://review.coreboot.org/c/coreboot/+/63289/5/src/soc/qualcomm/common/clo... ?
-
Shelley Chen (Code Review)