Change in coreboot[master]: WIP: soc/amd/common/block/lpc: Don't disable the HOG bit - coreboot-gerrit

13 Jul 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56233 )
Change subject: WIP: soc/amd/common/block/lpc: Don't disable the HOG bit
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/lpc/lpc.c:
https://review.coreboot.org/c/coreboot/+/56233/comment/b1e8c680_8cb7d835 
PS2, Line 69: 	// byte &= ~LPC_NOHOG;
is this commented out line going to confuse future generations?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56233
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If015869657f36d3533f4ab9ebd1f54b0d4eb283a
Gerrit-Change-Number: 56233
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Peers epeers@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 13 Jul 2021 00:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment