Sricharan Ramabadhran has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29954 )
Change subject: qcs405: Add DRAM resources ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/soc... File src/soc/qualcomm/qcs405/include/soc/symbols.h:
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/include/soc... PS13, Line 29: extern u8 _dram_reserved[];
DECLARE_REGION as introduced in 7e0dea6317d
ok
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/soc.c File src/soc/qualcomm/qcs405/soc.c:
https://review.coreboot.org/#/c/29954/13/src/soc/qualcomm/qcs405/soc.c@24 PS13, Line 24: ram_resource(dev, 0, (uintptr_t)_dram / KiB, DRAMSIZE1GB / KiB);
1 * GiB […]
ok, will fix
-
Sricharan Ramabadhran (Code Review)