Attention is currently required from: Timofey Komarov, Felix Singer, Angel Pons, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/349f73da_f7c5e84f PS5, Line 19: select SOC_INTEL_COMMON_SKYLAKE_BASE You can also select SKYLAKE_SOC_PCH_H here.
https://review.coreboot.org/c/coreboot/+/52692/comment/3336e067_70b67be5 PS5, Line 95: default 16 if MAINBOARD_SUPPORTS_COFFEELAKE_CPU
I'd do this in CB:52693
Alternatively, keep it in this change, but adapt the commit message; i.e. make it about the platform not the FSP. e.g. something like:
soc/intel/skylake: Add Kconfig option for LGA1151v2
Provide a SOC_INTEL_SKYLAKE_LGA1151_V2 option to select correct defaults for the combination of a Union Point PCH with LGA1151v2. This includes:
FSP...
MAX_CPUS...
PCH_H...