Jesper Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48226 )
Change subject: volteer/variants/volteer2: Goodix touch panel power-on sequence tuning ......................................................................
volteer/variants/volteer2: Goodix touch panel power-on sequence tuning
1. generic.reset_delay_ms change to 30
Change-Id: Ic23ffab78d3f52c41917dc2794506ccd7dffe8b4 --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/48226/1
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index a1012a6..3b3603c 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -161,7 +161,7 @@ register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)" # Parameter T3 >= 10ms - register "generic.reset_delay_ms" = "120" + register "generic.reset_delay_ms" = "30" # Parameter T2 >= 1ms register "generic.reset_off_delay_ms" = "3" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48226
to look at the new patch set (#2).
Change subject: volteer/variants/volteer2: Goodix touch panel power-on sequence tuning ......................................................................
volteer/variants/volteer2: Goodix touch panel power-on sequence tuning
1. generic.reset_delay_ms change to 30
Change-Id: Ic23ffab78d3f52c41917dc2794506ccd7dffe8b4 --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/48226/2
Jesper Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48226 )
Change subject: volteer/variants/volteer2: Goodix touch panel power-on sequence tuning ......................................................................
Patch Set 2: Code-Review-1
For Volteer reference
Jesper Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48226 )
Change subject: volteer/variants/volteer2: Goodix touch panel power-on sequence tuning ......................................................................
Abandoned