Attention is currently required from: Jon Murphy.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62153 )
Change subject: mb/google/skyrim: Add ACPI configuration for USB ports
......................................................................
Patch Set 37:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62153/comment/fc9318b2_7351feb9
PS37, Line 79: 2.3
You are right. It should be 2.0. Here is the port enumeration code: https://source.chromium. […]
ok, i'll push a patch to change that usb port id.
there are 3 new pci ids for the 3 xhci controllers:
#define PCI_DID_AMD_FAM17H_MODELA0H_XHCI0 0x1503
#define PCI_DID_AMD_FAM17H_MODELA0H_XHCI1 0x1504
#define PCI_DID_AMD_FAM17H_MODELA0H_XHCI2 0x1505
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62153
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1b05f190f25dca1566e1023011cc70c2d32f461
Gerrit-Change-Number: 62153
Gerrit-PatchSet: 37
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Comment-Date: Wed, 09 Mar 2022 18:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment