Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/20074 )
Change subject: soc/intel/cannonlake: Use common GPIO driver ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/20074/1/src/soc/intel/cannonlake/include/soc... File src/soc/intel/cannonlake/include/soc/gpio_defs.h:
https://review.coreboot.org/#/c/20074/1/src/soc/intel/cannonlake/include/soc... PS1, Line 151: #define GPP_F0_IRQ 0x0 Typo? IRQ 0 always revered for timer irq.
https://review.coreboot.org/#/c/20074/1/src/soc/intel/cannonlake/include/soc... PS1, Line 199: #define GPP_H1_IRQ 0x48 extra tab here?