Attention is currently required from: Anil Kumar K, Bora Guvendik, Hannah Williams, Jamie Ryu, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )
Change subject: soc/intel/common/block/pmc: Add GPE1 functions ......................................................................
Patch Set 11:
(4 comments)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/84104/comment/85fbe16a_9f9e2ca6?usp... : PS10, Line 296: : /* GPE */ : __weak const char *const *soc_std_gpe1_sts_array(int idx, size_t *a) : { : return NULL; : } : : /* disable the corresponding GPE1 bits based on standard GPE0 bits */ : __weak void soc_pmc_disable_std_gpe1(uint32_t gpe0_mask) : { : } : : /* enable the corresponding GPE1 bits based on standard GPE0 bits */ : __weak void soc_pmc_enable_std_gpe1(uint32_t gpe0_mask) : { : }
move this _weak implementation the file beginning and a comment saying `/* SoC overrides for GPE1 wh […]
Done
https://review.coreboot.org/c/coreboot/+/84104/comment/f8e733a8_0baea8a0?usp... : PS10, Line 329: pmc_disable_gpe1
can you please move this API after `pmc_disable_gpe0`?
Done
https://review.coreboot.org/c/coreboot/+/84104/comment/4c8826f8_6b99121f?usp... : PS10, Line 396: reset_std_gpe1_status
move after `reset_std_gpe0_status`
Done
https://review.coreboot.org/c/coreboot/+/84104/comment/f9f52395_25ed52ea?usp... : PS10, Line 406: print_std_gpe1_sts
move after `print_std_gpe0_sts`?
Done