Attention is currently required from: Jason Glenesk, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56273 )
Change subject: soc/amd/picasso: add missing banks to mca_bank_name array
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/56273/comment/b30674d3_a6d66b78
PS3, Line 145: [7] = "L3 cache unit",
: [8] = "L3 cache unit",
: [9] = "L3 cache unit",
: [10] = "L3 cache unit",
: [11] = "L3 cache unit",
: [12] = "L3 cache unit",
: [13] = "L3 cache unit",
: [14] = "L3 cache unit",
I'm pretty sure the compiler will perform string interning, so I don't think it's a problem.
ran strings on the .o file and the "L3 cache unit" string is only in there once, so no need to fix what's not broken
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10a65210da73e64b67d613609fcc0f9a245a81fb
Gerrit-Change-Number: 56273
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 14 Jul 2021 20:49:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment