Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Zhanzhan Ge has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email )
Change subject: soc/mediatek/mt8196: Fix timer reset in BL31 ......................................................................
Patch Set 21:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83928/comment/1bf83e16_1e7d0430?usp... : PS8, Line 9: 1. Set systimer compensation to version 2.0. : 2. The system does not need to serve pending IRQ from systimer : after rebooting. Therefore we clear systimer IRQ pending bit : at early booting.
Okay, then they can be in the same patch. […]
Done
File src/soc/mediatek/mt8196/timer_prepare.c:
https://review.coreboot.org/c/coreboot/+/83928/comment/68520884_5821081b?usp... : PS8, Line 18: &mtk_systimer->cnttval[id].con
I mean another variable, so that we don't need to perform duplicate `->cnttval[id].con` lookup.
Done
https://review.coreboot.org/c/coreboot/+/83928/comment/025c5341_9217abef?usp... : PS8, Line 28: clrbits32
The difference between clrbits32 and clrbits32p is whether the first parameter is a pointer […]
Done