Attention is currently required from: Kapil Porwal, Karthik Ramasubramanian, Paul Menzel, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85218?usp=email )
Change subject: util/cbfstool: Add eventLog support for ELOG_TYPE_FW_CSE_SYNC ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85218/comment/bb4e0c3f_54d69735?usp... : PS1, Line 14: TEST=boot verified on google/rex0
Paste the new log lines?
This patch just adds support for the new events log. These events will be used in subsequent patches and output has pasted there.
File util/cbfstool/eventlog.c:
https://review.coreboot.org/c/coreboot/+/85218/comment/71397cc3_b903656b?usp... : PS1, Line 173: cse
`CSE` this an acronym
Acknowledged
https://review.coreboot.org/c/coreboot/+/85218/comment/3da6ce9e_6ef0079a?usp... : PS1, Line 494: {ELOG_FW_ROMSTAGE_CSE_SYNC, "ROMSTAGE performed CSE sync"}, : {ELOG_FW_RAMSTAGE_CSE_SYNC, "RAMSTAGE performed CSE sync"}, : {ELOG_FW_PAYLOAD_CSE_SYNC, "PAYLOAD performed CSE sync"},
Acknowledged
https://review.coreboot.org/c/coreboot/+/85218/comment/0be1d3c1_c9e98f48?usp... : PS1, Line 522: [ELOG_TYPE_FW_CSE_SYNC] = sizeof(uint8_t),
Nit: Add extra tabs to align `= RHS` with the rest of the lines.
Acknowledged