Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35616 )
Change subject: [NOTFORMERGE] fsp_broadwell_de: Break __ROMCC__ bootblock ......................................................................
[NOTFORMERGE] fsp_broadwell_de: Break __ROMCC__ bootblock
Change-Id: I46c709019e832af179dc26218086f7a7b13850b7 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/intel/microcode/microcode.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35616/1
diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c index 80470bf..cd6de70 100644 --- a/src/cpu/intel/microcode/microcode.c +++ b/src/cpu/intel/microcode/microcode.c @@ -184,6 +184,7 @@ if (ucode_updates->total_size) { update_size = ucode_updates->total_size; } else { + do {} while (0); printk(BIOS_SPEW, "Microcode size field is 0\n"); update_size = 2048; }
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35616 )
Change subject: [NOTFORMERGE] fsp_broadwell_de: Break __ROMCC__ bootblock ......................................................................
Patch Set 1: Code-Review-2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35616 )
Change subject: [NOTFORMERGE] fsp_broadwell_de: Break __ROMCC__ bootblock ......................................................................
Patch Set 1:
I quess we don't really care about util/romcc enough to improve its optimisations.
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35616 )
Change subject: [NOTFORMERGE] fsp_broadwell_de: Break __ROMCC__ bootblock ......................................................................
Abandoned
-
Kyösti Mälkki (Code Review)