Attention is currently required from: Rob Barnes, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63598 )
Change subject: util/apcb/apcb_v3_edit.py: Edit APCB based on different SPD magic
......................................................................
Patch Set 1:
(2 comments)
File util/apcb/apcb_v3_edit.py:
https://review.coreboot.org/c/coreboot/+/63598/comment/345973a5_89836d58
PS1, Line 84: if args.spd_magic:
: SPD_MAGIC = bytes.fromhex(args.spd_magic)
Can you use a local variable instead?
```
if args.spd_magic:
spd_magic = bytes.fromhex(args.spd_magic)
else:
spd_magic = SPD_MAGIC
```
https://review.coreboot.org/c/coreboot/+/63598/comment/1818aca5_df3d6f5f
PS1, Line 97: SPD_MAGIC
Switch this to use `spd_magic`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e96c89e4e5ce8e0567a17bf7685b69080fa1708
Gerrit-Change-Number: 63598
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 13 Apr 2022 16:42:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment