Change in coreboot[master]: ChromeOS: Add legacy mainboard_ec_running_ro() - coreboot-gerrit

18 Nov 2021


      Attention is currently required from: Tim Wawrzynczak, Kyösti Mälkki.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro()
......................................................................
Patch Set 7:
(1 comment)
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/58896/comment/58bdfc47_d1457dfd 
PS7, Line 67: 	}
...
...
... Can't we just get rid of this and related callbacks? […]
Okay, great... honestly then I'd say just rip this out and leave it to depthcharge. There's no reason to worry about this here. Just leave the fields in the struct zeroed out.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58896
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cb95268424dc27f8c1e26b3d34eff1a7b8eab7f
Gerrit-Change-Number: 58896
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 18 Nov 2021 22:57:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment