Attention is currently required from: Jason Glenesk, Marshall Dawson, Rob Barnes, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62598 )
Change subject: soc/amd/common/block: Add mainboard_handle_smi ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/cpu/smm/smi_handler.c:
https://review.coreboot.org/c/coreboot/+/62598/comment/84d96b94_d087558f PS1, Line 12: printk(BIOS_WARNING, "SMI event %d is missing handler\n", event);
Will this be logging unnecessarily for any previously unhandled SMIs?
Hrmm, you bring up a good point. Zork and guybrush don't have any other SMIs currently enabled, so we shouldn't be printing anything. They implement mainboard_smi_gpi to print a message: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
Grunt on the other hand does rely on the GPE SMI: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
It uses the `mainboard_smi_gpi` handler to handle this. So this means that on Grunt when we get the EC SMI, we will print this error, and then below we will handle the SMI. So I think we need to migrate everyone from using `mainboard_smi_gpi` to `mainboard_handle_smi`. That method is defined as part of the SMM handler header: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
So we really can't deprecate it. I guess I can change this weak method to check if the event is a gevent and not log anything. I'll do that.
-
Raul Rangel (Code Review)