Attention is currently required from: Felix Singer, Xue Yao, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens.
insurgo@riseup.net has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 22:
(1 comment)
Patchset:
PS22:
For Heads, I cherry-picked commits for coreboot 4.13 (I know, old) […]
On top of 4.19, I had to modify patch obtained by
git fetch https://review.coreboot.org/coreboot refs/changes/50/28950/22 && git format-patch -1 --stdout FETCH_HEAD
Tested with coreboot config:
# CONFIG_USE_BLOBS is not set
CONFIG_VENDOR_LENOVO=y
CONFIG_NO_POST=y
CONFIG_ONBOARD_VGA_IS_PRIMARY=y
CONFIG_CBFS_SIZE=0xBE4FFF
CONFIG_INTEL_GMA_VBT_FILE="src/mainboard/$(MAINBOARDDIR)/variants/x230_edp/data.vbt"
CONFIG_IFD_BIN_PATH="@BLOB_DIR@/xx30/ifd.bin"
CONFIG_ME_BIN_PATH="@BLOB_DIR@/xx30/me.bin"
CONFIG_GBE_BIN_PATH="@BLOB_DIR@/xx30/gbe.bin"
CONFIG_HAVE_IFD_BIN=y
CONFIG_BOARD_LENOVO_X230_EDP=y
CONFIG_LINUX_COMMAND_LINE="intel_iommu=igfx_off quiet"
CONFIG_UART_PCI_ADDR=0
CONFIG_HAVE_ME_BIN=y
CONFIG_HAVE_GBE_BIN=y
CONFIG_DRIVERS_PS2_KEYBOARD=y
CONFIG_TPM_MEASURED_BOOT=y
CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x80000
CONFIG_PAYLOAD_LINUX=y
CONFIG_PAYLOAD_FILE="@BOARD_BUILD_DIR@/bzImage"
CONFIG_LINUX_INITRD="@BOARD_BUILD_DIR@/initrd.cpio.xz"
Building at coreboot 4.13 -> 4.19 coreboot version bump at https://app.circleci.com/pipelines/github/tlaurion/heads/1452/workflows/fc66...
For WiP commit https://github.com/tlaurion/heads/commit/1112a58fe7841dcb93e2d8bf498f498d458... where
Modified patch successfully applying locally on top of 4.19 release at https://github.com/tlaurion/heads/commit/1112a58fe7841dcb93e2d8bf498f498d458...
Note override of CONFIG_INTEL_GMA_VBT_FILE above in config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 22
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kilian Neuner
cb@9-r.net
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aleksei Kharlamov
derlafff@ya.ru
Gerrit-CC: Charles Moyes
thechuckster@gmail.com
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Pavel Kovalenko
su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Stanislaw Kaminski
stanislaw.kaminski@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao
xueyao@xyte.ch
Gerrit-CC: clayton craft
Gerrit-CC: insurgo@riseup.net
Gerrit-CC: nullmark
nullmark@googlemail.com
Gerrit-CC: slact
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Xue Yao
xueyao@xyte.ch
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kilian Neuner
cb@9-r.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Charles Moyes
thechuckster@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 15 Feb 2023 18:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: insurgo@riseup.net
Gerrit-MessageType: comment