Attention is currently required from: Naveen M, Paul Menzel, Subrata Banik.
Anil Kumar K has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81920/comment/c91b55dd_ad04f708?usp... :
PS7, Line 32: reference datasheet : Realtek ALC722-CG ver. 0.56
I’d add it above the TEST= line.
Done
https://review.coreboot.org/c/coreboot/+/81920/comment/e62378bd_4d5df17d?usp... :
PS7, Line 32: reference datasheet :
Remove the space before the colon?
Done
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/81920/comment/da20987a_98c69c43?usp... :
PS7, Line 22: #endif
there should be a else case to handle a scenario where user might have selected DRIVERS_SOUNDWIRE_AL […]
Done
https://review.coreboot.org/c/coreboot/+/81920/comment/b7d3030b_8a73f7ef?usp... :
PS7, Line 162: .name = "Realtek ALC722 SoundWire Codec",
add a else case with "unknown" may be ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 8
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Naveen M
naveen.m@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Naveen M
naveen.m@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 08 Aug 2024 22:58:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org