Attention is currently required from: Arthur Heymans, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59131 )
Change subject: device/pci_device.c: Improve pci_bridge_route() readability
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/59131/comment/7d4ae1b0_eccc0026
PS1, Line 1337: u32 raw;
: struct {
: u8 primary;
: u8 secondary;
: u8 subordinate;
: u8 _latency;
: } __packed;
Depends on the implementation of pci_write_config32(). IMHO, it should be […]
Thanks!
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/59131/comment/778640c8_81100ade
PS3, Line 1347: secondary
subordinate
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bafd6a2e1d3a0b8d1d43997868a787ce3940ca9
Gerrit-Change-Number: 59131
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 19 Nov 2021 13:25:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment