Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83621?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/*: Add the subsystem ids for HDA ......................................................................
mb/starlabs/*: Add the subsystem ids for HDA
The Windows drivers require the subsystem ID to match on the PCI device, so set these to allow the driver to install.
Change-Id: I01b36554d5322018efc72734a8e749cc06263577 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/83621 Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/starlabs/lite/variants/glk/devicetree.cb M src/mainboard/starlabs/lite/variants/glkr/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb 7 files changed, 13 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb index 2f58a7b..6c0269b 100644 --- a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb @@ -66,7 +66,9 @@ device ref p2sb on end device ref fast_spi on end device ref sram on end - device ref hda on end + device ref hda on + subsystemid 0x10ec 0x111e + end device ref heci1 on end device ref heci2 on end device ref heci3 on end diff --git a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb index fe32143c5d..bfe9d51 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb @@ -66,7 +66,9 @@ device ref p2sb on end device ref fast_spi on end device ref sram on end - device ref hda on end + device ref hda on + subsystemid 0x10ec 0x111e + end device ref heci1 on end device ref heci2 on end device ref heci3 on end diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index bbc428e..b9e449f 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -173,6 +173,7 @@ end end device ref hda on + subsystemid 0x1e50 0x7007 register "pch_hda_sdi_enable[0]" = "1" register "pch_hda_audio_link_hda_enable" = "1" register "pch_hda_idisp_codec_enable" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 448fc29..81d593f 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -141,6 +141,7 @@ end end device ref hda on + subsystemid 0x10ec 0x1200 register "PchHdaAudioLinkHda" = "1" end device ref smbus on end diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index 42047b2..08f5006 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -139,7 +139,9 @@ device pnp 4e.19 off end # Power Management Channel 5 end end - device ref hda on end + device ref hda on + subsystemid 0x10ec 0x10d0 + end device ref smbus on end device ref fast_spi on end end diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index c7b8738..ac3ebdc 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -168,6 +168,7 @@ end end device ref hda on + subsystemid 0x1e50 0x7007 register "pch_hda_sdi_enable[0]" = "1" register "pch_hda_audio_link_hda_enable" = "1" register "pch_hda_idisp_codec_enable" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index c29d7c9..26197a2 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -189,6 +189,7 @@ end end device ref hda on + subsystemid 0x10ec 0x1200 register "PchHdaAudioLinkHdaEnable" = "1" end device ref smbus on end