Attention is currently required from: Dehui Sun, Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )
Change subject: soc/mediatek/mt8196: Add booker driver
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/mt8196/booker.c:
https://review.coreboot.org/c/coreboot/+/85362/comment/22566422_76d44d72?usp... :
PS5, Line 56: __func__
Align with BIOS_DEBUG.
File src/soc/mediatek/mt8196/include/soc/booker.h:
https://review.coreboot.org/c/coreboot/+/85362/comment/1fbd8b2f_bdf4c0ca?usp... :
PS5, Line 6: extern
remove
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85362?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6bde1e20137890addf18b23b47f17b1f63824b22
Gerrit-Change-Number: 85362
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Dehui Sun
dehui.sun@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Dehui Sun
dehui.sun@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Mon, 02 Dec 2024 08:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No