Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68783 )
Change subject: mb/prodrive/atlas: Add IBECC Kconfig option ......................................................................
mb/prodrive/atlas: Add IBECC Kconfig option
Add an option on Atlas to enable IBECC (In Band Error Correction Code), which is currently needed for endurance testing.
Test: start atlas mainboard with Linux. See in dmesg that IBECC (EDAC igen6) driver is loaded. Inject a fake error via debugfs and see in dmesg that Linux handles it.
Signed-off-by: Maximilian Brune maximilian.brune@9elements.com Change-Id: I71ee2401136e2dc70b3164db6c99af03a3e1f346 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68783 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com --- M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/devicetree.cb 2 files changed, 30 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved
diff --git a/src/mainboard/prodrive/atlas/Kconfig b/src/mainboard/prodrive/atlas/Kconfig index f986a2d..814c1e0 100644 --- a/src/mainboard/prodrive/atlas/Kconfig +++ b/src/mainboard/prodrive/atlas/Kconfig @@ -19,6 +19,13 @@ bool "Enable SaGv" default y
+config ATLAS_ENABLE_IBECC + bool "Enable IBECC" + help + Enables In Band Error Correction Code. It's only needed for endurance testing + and therefore not always required. + default n + config MAINBOARD_FAMILY string default "PRODRIVE_ATLAS_SERIES" diff --git a/src/mainboard/prodrive/atlas/devicetree.cb b/src/mainboard/prodrive/atlas/devicetree.cb index 6e795a7..0d91bb6 100644 --- a/src/mainboard/prodrive/atlas/devicetree.cb +++ b/src/mainboard/prodrive/atlas/devicetree.cb @@ -47,6 +47,9 @@ register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC1)" register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC1)"
+ register "ibecc.enable" = "CONFIG(ATLAS_ENABLE_IBECC)" + register "ibecc.mode" = "CONFIG(ATLAS_ENABLE_IBECC) ? IBECC_MODE_ALL : IBECC_MODE_NONE" + register "sata_salp_support" = "1"
register "sata_ports_enable" = "{