Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58352 )
Change subject: soc/intel/alderlake: enable gpio locking
......................................................................
Patch Set 2:
(2 comments)
File src/soc/intel/alderlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/58352/comment/32eea5e7_387c8ffe
PS1, Line 251: #if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)
Yes, once you add a weak soc_gpio_lock_config override, you dont need this guard. […]
I think you can make it work without any #ifs whatsoever and no weak functions either.
Basically by selecting the Kconfig, then the SoC should be obligated to define that function; that seems fine, and then common code can use
`if (CONFIG(BLAH))`
https://review.coreboot.org/c/coreboot/+/58352/comment/883146d1_95b43f83
PS1, Line 250:
: #if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)
I don't think this is required
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58352
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I457bab39f945ab31a89542c6498a73af70cbf9ee
Gerrit-Change-Number: 58352
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 29 Oct 2021 19:08:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment