Attention is currently required from: Shelley Chen, Hung-Te Lin, Furquan Shaikh, Paul Menzel, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 )
Change subject: soc/mediatek: Add PCIe support
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56791/comment/02fa8b4e_6f16ce41
PS3, Line 11:
Since this file is not platform related, I'm not sure if this is a good idea to add this comment i […]
Ack
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/56791/comment/84e1aad3_0504b512
PS3, Line 85: static inline int mtk_fls(int x)
Maybe commonlib/bsd/include/commonlib/bsd/helpers. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0
Gerrit-Change-Number: 56791
Gerrit-PatchSet: 5
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 30 Nov 2021 06:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-MessageType: comment