Attention is currently required from: Nico Huber, Sridhar Siricilla, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61380 )
Change subject: soc/inte/common: Add support to control coreboot and Intel SoC features ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/61380/comment/3ffe5451_41c6c7aa PS2, Line 666: is_cse_fw_update_enabled
So, if I read it correctly there is no restriction while reading OEM sections prior or post FSI. hence, why we would like to introduce a Kconfig to guard the read operation which would eventually get drop during FSI. Any owner for ensuring the same across program ?
I don't see any benefit running this code since it is not useful once RO is locked. Hence, I want to guard the code and remove it before FSI.
As I have highlighted earlier adding Kconfig is always costly plus its maintenance effort, who will maintain this addition and deletion, plus pulling that CL into upstream chromium etc. etc..
If there is no restriction (which I read is none), do you know about any time penalty if we wish to have this OEM section read unconditionally?
I could sense there are some underlying assumption which is not documented anything, either please raise a bug or write a .md file to clear out those assumptions.
There are no assumptions or hidden things in this regard, I will update commit message with more information.
Here are assumption which is not documented 1. Using OEM section for storing SoC debug information. which ideally can be managed using a soft-strap under debug strap. 2. Default value for bit-field, example: `1` is disable and `0` is enable or vice versa, 3. Any restriction this OEM region read need to be discarded in in FSI image. if yes, what is the boot time impact. 4. Comment suggests that, there are plan to add more configuration using OEM region and added a library. But what those configuration are not very clear just reading the commit msg.