Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63003 )
Change subject: mb/google/skyrim: Fix Backlight GPIO ......................................................................
mb/google/skyrim: Fix Backlight GPIO
Backlight GPIO was set to HIGH, when it should have been set LOW to enable the backlight in the embedded display.
BUG=b:224618411 TEST=load on Skyrim proto1, observe backlight
Signed-off-by: Jon Murphy jpmurphy@google.com Change-Id: Ife3335ca5a3c2517a6817fccf0544e5fcacb1f9d --- M src/mainboard/google/skyrim/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/63003/1
diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c index f095651..ac296ad 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c +++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c @@ -61,7 +61,7 @@ /* EN_PP3300_TCHSCR */ PAD_GPO(GPIO_29, HIGH), /* SOC_DISABLE_DISP_BL */ - PAD_GPO(GPIO_30, HIGH), + PAD_GPO(GPIO_30, LOW), /* Unused */ PAD_NC(GPIO_31), /* LPC_RST_L */