Change in coreboot[master]: ec/google/chromeec/acpi: Drop wrong _ADR object

List overview All Threads
Download

newer

older

Change in coreboot[master]: (acpi)...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

23 Oct 2019 23 Oct '19

6:17 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

ec/google/chromeec/acpi: Drop wrong _ADR object

Use a _HID but not _HID and _ADR.

Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/36260/1

diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index c521a3a..9c0fa68 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -40,7 +40,6 @@ Device (ECMM) { Name (_HID, EISAID ("PNP0C02")) Name (_UID, 4) - Name (_ADR, 0)

Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -64,7 +63,6 @@ Device (ECUI) { Name (_HID, EISAID ("PNP0C02")) Name (_UID, 3) - Name (_ADR, 0)

Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -109,7 +107,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)

Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -137,7 +134,6 @@ Device (PS2K) // Keyboard { Name (_UID, 0) - Name (_ADR, 0) Name (_HID, "GOOG000A") Name (_CID, Package() { EISAID("PNP0303"), EISAID("PNP030B") } )

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Aaron Durbin (Code Review)

23 Oct 23 Oct

7:27 a.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

Patch Set 2:

Could you please elaborate in the commit description that makes it wrong.

It currently implies that _HID with _ADR is incorrect, but I think that could be expanded upon. Mention something in ACPI spec?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 23 Oct 2019 14:27:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

9:31 a.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

Patch Set 2: Code-Review+2

"A device object must contain either an _HID object or an _ADR object, but should not contain both"

Some of the true legacy superio devices do need _ADR but not the ones with a PNP ID.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 23 Oct 2019 16:31:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:43 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 23 Oct 2019 16:43:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10 a.m.

Hello Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36260

to look at the new patch set (#3).

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

ec/google/chromeec/acpi: Drop wrong _ADR object

A device object must contain either an _HID object or an _ADR object, but should not contain both.

Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/36260/3

Furquan Shaikh (Code Review)

10:04 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 23 Oct 2019 17:04:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:05 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36260/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36260/3//COMMIT_MSG@9 PS3, Line 9: A device object must contain either an _HID object or an _ADR object, ACPI Version 6.3 Section 6.1:

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 23 Oct 2019 17:05:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:06 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36260/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36260/3//COMMIT_MSG@9 PS3, Line 9: A device object must contain either an _HID object or an _ADR object,

...

ACPI Version 6.3 Section 6. […]

Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Wed, 23 Oct 2019 17:06:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:07 a.m.

Hello Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36260

to look at the new patch set (#4).

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

ec/google/chromeec/acpi: Drop wrong _ADR object

ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."

Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/36260/4

Patrick Georgi (Code Review)

24 Oct 24 Oct

8:51 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36260/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/36260/3//COMMIT_MSG@9 PS3, Line 9: A device object must contain either an _HID object or an _ADR object,

...

Thx

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 24 Oct 2019 15:51:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8:51 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36260 )

Change subject: ec/google/chromeec/acpi: Drop wrong _ADR object ......................................................................

ec/google/chromeec/acpi: Drop wrong _ADR object

ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both."

Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36260 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 0 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved

Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -64,7 +63,6 @@ Device (ECUI) { Name (_HID, EISAID ("PNP0C02")) Name (_UID, 3) - Name (_ADR, 0)

Method (_STA, 0, NotSerialized) { Return (0x0F) @@ -109,7 +107,6 @@ Device (COM1) { Name (_HID, EISAID ("PNP0501")) Name (_UID, 1) - Name (_ADR, 0)

-- To view, visit https://review.coreboot.org/c/coreboot/+/36260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb54664a6528ce67634991f64a5f3c411822cdf4 Gerrit-Change-Number: 36260 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1851

days inactive

1852

days old

coreboot-gerrit@coreboot.org

10 comments

5 participants

tags (0)

participants (5)

Aaron Durbin (Code Review)
Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)