Change in ...coreboot[master]: mb/google/hatch: Fine tune Goodix touch screen timing

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Dtrain Hsu (Code Review)

7 May 2019 7 May '19

6:51 a.m.

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32665

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

mb/google/hatch: Fine tune Goodix touch screen timing

According to Goodix GT7375P datasheet, fine tune Goodix touch screen timing.

BUG=b:129727745 BRANCH=None TEST=local build and tested with Goodix touch screen worked under coldboot(10 times), warmboot(10 times), S3(10 times).

Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32665/1

diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 42752e6..562bb8b 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -78,8 +78,8 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "30" - register "generic.reset_off_delay_ms" = "3" + register "generic.reset_delay_ms" = "10" + register "generic.reset_off_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 5d on end diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb index 115a513..eec7880 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb @@ -63,8 +63,8 @@ register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "30" - register "generic.reset_off_delay_ms" = "3" + register "generic.reset_delay_ms" = "10" + register "generic.reset_off_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 5d on end

Attachments:

attachment.htm (text/html — 4.5 KB)

Show replies by thread

Paul Menzel (Code Review)

7 May 7 May

10:09 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@9 PS1, Line 9: fine tune reduce

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 07 May 2019 10:09:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

10:10 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@14 PS1, Line 14: coldboot(10 times), warmboot(10 times), S3(10 times). Please add a space before (.

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@16 PS1, Line 16: Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Please move that below the Change-Id line.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 07 May 2019 10:10:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

5:52 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 07 May 2019 17:52:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:18 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 07 May 2019 18:18:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

10:25 p.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Tue, 07 May 2019 22:25:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

8 May 8 May

2 a.m.

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32665

to look at the new patch set (#2).

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

mb/google/hatch: Fine tune Goodix touch screen timing

According to Goodix GT7375P datasheet, reduce Goodix touch screen timing.

BUG=b:129727745 BRANCH=None TEST=local build and tested with Goodix touch screen worked under coldboot (10 times), warmboot (10 times), S3 (10 times).

Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32665/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

3:21 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 08 May 2019 15:21:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

5:42 p.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 08 May 2019 17:42:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Dtrain Hsu (Code Review)

9 May 9 May

2:39 a.m.

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

Patch Set 2:

(3 comments)

...

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@9 PS1, Line 9: fine tune

...

reduce

Done

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@14 PS1, Line 14: coldboot(10 times), warmboot(10 times), S3(10 times).

...

Please add a space before (.

Done

https://review.coreboot.org/#/c/32665/1//COMMIT_MSG@16 PS1, Line 16: Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com

...

Please move that below the Change-Id line.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 09 May 2019 02:39:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

10 May 10 May

3:14 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32665 )

Change subject: mb/google/hatch: Fine tune Goodix touch screen timing ......................................................................

mb/google/hatch: Fine tune Goodix touch screen timing

According to Goodix GT7375P datasheet, reduce Goodix touch screen timing.

BUG=b:129727745 BRANCH=None TEST=local build and tested with Goodix touch screen worked under coldboot (10 times), warmboot (10 times), S3 (10 times).

Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32665 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve

-- To view, visit https://review.coreboot.org/c/coreboot/+/32665 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4bf081bab5e89d3ce336c6432da5ba71279fa98d Gerrit-Change-Number: 32665 Gerrit-PatchSet: 3 Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-MessageType: merged

1835

days inactive

1838

days old

coreboot-gerrit@coreboot.org

10 comments

6 participants

tags (0)

participants (6)

Dtrain Hsu (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)
Shelley Chen (Code Review)
Tim Wawrzynczak (Code Review)