Attention is currently required from: Felix Singer, Jeff Daly, Suresh Bellampalli, Patrick Rudolph, Elyes Haouas.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60992 )
Change subject: soc/intel/denverton_ns: enable Denverton to use common SoC XHCI code
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/soc/intel/denverton_ns/chip.h:
https://review.coreboot.org/c/coreboot/+/60992/comment/bb2ca7e6_c83a79bf
PS10, Line 6: #include <acpi/acpi_device.h>
please, why this include ?
Ping!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I505b3a7761cb3719697626e1f272d0928fdd29f1
Gerrit-Change-Number: 60992
Gerrit-PatchSet: 11
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 12 Apr 2022 23:30:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment