Attention is currently required from: Elyes Haouas, Martin L Roth, Maximilian Brune, Nicholas Chin, Patrick Rudolph, Sean Rhodes.
Lean Sheng Tan has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/77882?usp=email )
Change subject: include/commonlib/sot.h: Add SOT structs ......................................................................
Patch Set 14:
(3 comments)
File Documentation/drivers/cfr.md:
https://review.coreboot.org/c/coreboot/+/77882/comment/1ff63f47_5d533da7?usp... : PS9, Line 21: The coreboot table is generated from coreboot ramstage : code. :
I think for know it makes sense to just leave the SOT/CFR stuff to ramstage. […]
Any thoughts @gaumless@gmail.com? if not will mark it as close, thanks 😊
https://review.coreboot.org/c/coreboot/+/77882/comment/cbadeb26_eeb1b828?usp... : PS9, Line 25: tatus flags.
Currently I assume the values are stored in an EFI variable store, since that is my current use case […]
Any thoughts @gaumless@gmail.com? if not will mark it as close, thanks 😊
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/77882/comment/ffeb9ad9_8e308872?usp... : PS9, Line 102:
Shouldn't a version for the entire SOT suffice? Although for now I would leave the versioning out si […]
Any thoughts @gaumless@gmail.com? if not will mark it as close, thanks 😊