Attention is currently required from: Felix Singer, Martin L Roth, Nico Huber, Nigel Tao, Paul Menzel.
Jonathon Hall has posted comments on this change by Jonathon Hall. ( https://review.coreboot.org/c/coreboot/+/83476?usp=email )
Change subject: bootsplash: Increase heap from 1 MB to 4 MB when bootsplash is enabled ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Is 4 MB so large to be problematic? I'm familiar with Wuffs but not so familiar with coreboot. […]
I don't have a problem with 4 MB. I don't think it'd be a problem anywhere (I don't think coreboot supports anything old enough for 4 MB to be an appreciable chunk of RAM), but I'm not familiar enough with every board and chipset to be sure.
I can certainly raise the default heap from 1 MB to 4 MB without depending on the bootsplash config if we agree that's reasonable. Any objections?
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/83476/comment/f8a2531a_505051fe?usp... : PS2, Line 507: default 0x400000 if BOOTSPLASH
Why not adding this as another default to src/Kconfig?
I can move it over there, I don't really have a preference