[M] Change in coreboot[main]: soc/intel/common/block: Add support for watchdog

[Subrata Banik (Code Review)]

Attention is currently required from: Marek Maślanka, Michał Żygowski.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: soc/intel/common/block: Add support for watchdog
......................................................................

Patch Set 12:

(8 comments)

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/5f7d46d2_cc936036 :
PS12, Line 395: wdat
missed the NULL check in the code ?

https://review.coreboot.org/c/coreboot/+/79909/comment/813ff9c5_fe75b2fc :
PS12, Line 397: tcobase
what if this address is zero like TCO is not enabled ?

https://review.coreboot.org/c/coreboot/+/79909/comment/3708525d_c2507363 :
PS12, Line 410: // write countdown
`
/* */
`

https://review.coreboot.org/c/coreboot/+/79909/comment/c9e26afe_e8c399f7 :
PS12, Line 461: 11
what is the meaning of the hardcoded value ?

https://review.coreboot.org/c/coreboot/+/79909/comment/217a597c_1bbae371 :
PS12, Line 468: 	entry->action = ACPI_WDAT_SET_RUNNING_STATE;
              : 	entry->instruction = ACPI_WDAT_WRITE_VALUE | ACPI_WDAT_PRESERVE_REGISTER;
              : 	entry->mask = 0x01;
              : 	entry->register_region.space_id = ACPI_ADDRESS_SPACE_IO;
              : 	entry->register_region.addrl = tcobase + TCO1_CNT;
              : 	entry->register_region.access_size = ACPI_WDAT_ACCESS_SIZE_WORD;
              : 	entry->register_region.bit_offset = 11;
can this be a helper function like

```
void fill_wdat_entry(acpi_wdat_t *wdat, int type)
{
    static uint16_t tcobase = tco_get_bar();

entry->action = type;
    entry->instruction = ACPI_WDAT_WRITE_VALUE | ACPI_WDAT_PRESERVE_REGISTER;
    entry->mask = 0x01;
    entry->register_region.space_id = ACPI_ADDRESS_SPACE_IO;
    entry->register_region.addrl = tcobase + TCO1_CNT;
    entry->register_region.access_size = ACPI_WDAT_ACCESS_SIZE_WORD;
    entry->register_region.bit_offset = 11;
}
```

```
entry++;
fill_wdat_entry(entry, ACPI_WDAT_SET_RUNNING_STATE);
entry++;
fill_wdat_entry(entry, ACPI_WDAT_SET_STOPPED_STATE);
```

File src/soc/intel/common/block/smbus/tco.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/6cbe062e_0aac60d4 :
PS12, Line 79: {
single statement, don't need braces

https://review.coreboot.org/c/coreboot/+/79909/comment/276d4a3d_61f9df34 :
PS12, Line 148: __weak
why weak ?

https://review.coreboot.org/c/coreboot/+/79909/comment/0cb20618_023024ca :
PS12, Line 149: u32
uint32_t