Attention is currently required from: Felix Singer, Julius Werner, Lean Sheng Tan, Maximilian Brune.
Nico Huber has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83615?usp=email )
Change subject: util/cbfstool/cbfs-payload-linux: Do not compress bzImage
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
File util/cbfstool/cbfs-payload-linux.c:
https://review.coreboot.org/c/coreboot/+/83615/comment/41e9624f_8ab4595c?usp... :
PS4, Line 58: }
This shouldn't get lost.
https://review.coreboot.org/c/coreboot/+/83615/comment/f02328f1_d33cd241?usp... :
PS4, Line 180: * size (ie. incompressible data)?
Does this still make sense?
https://review.coreboot.org/c/coreboot/+/83615/comment/9dff77fe_1be698f4?usp... :
PS4, Line 190:
I'd do the compression_function() lookup here, right away.
For the special case `compression_function(CBFS_COMPRESS_NONE)` I'd say it
doesn't matter where to do it, because it shouldn't return NULL by definition.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83615?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I022982667515ce721d98af534414d9e336b5f35a
Gerrit-Change-Number: 83615
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Tue, 06 Aug 2024 21:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes