Attention is currently required from: Andrey Petrov, Hannah Williams, Paul Menzel, Ronak Kanabar, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75524?usp=email )
Change subject: drivers/intel/fsp2_0: Read MRC version from FSP binary ......................................................................
Patch Set 12:
(3 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/75524/comment/382c7f43_bb77ae20 : PS3, Line 405: MRC_VERSION_FROM_BIN
@traun ADL/RPL changes will take some more time. I will share more details on bug. @subrata are we okay with MRC_VERSION_FROM_BIN given that we are planning to use MRC_VERSION_FROM_HEADER later ?
i don't kw how those would be different. IMO, we should try to create abstraction and make sure actual details being handled inside the driver. It’s too much expectation from soc users to kw to select between `version from binary` or `version from header`.
FSP_HEADER_HAS_MRC_VERSION_INFO_1 and FSP_HEADER_HAS_MRC_VERSION_INFO_2 with different help text would solve ur purpose.
File src/drivers/intel/fsp2_0/include/fsp/soc_binding.h:
https://review.coreboot.org/c/coreboot/+/75524/comment/83e148d0_b670b81b : PS12, Line 30: MRC_VERSION_FROM_BIN FSP_HEADER_HAS_MRC_VERSION
https://review.coreboot.org/c/coreboot/+/75524/comment/729e0c85_0e44184b : PS12, Line 32: TODO: Remove BUILD_TIME_STAMP_SIZE Macro from coreboot once Macro : * definition is in 'FspProducerDataHeader.h'. what is the timeline ? like next EDK2 uprev ?