[S] Change in coreboot[master]: acpi.c: Guard FACS generation - coreboot-gerrit

30 Jun 2023


      Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76178?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: acpi.c: Guard FACS generation
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76178/comment/3c0b8798_14131f71 :
PS1, Line 2053: 	current = ALIGN_UP(current, 64);
This seems specific to FACS. Move this in the if block and
the other one below?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76178?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a1f36616e7f6adb021625e62e0fdf81864c7ac3
Gerrit-Change-Number: 76178
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 30 Jun 2023 11:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment