Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Lean Sheng Tan.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 5:
(6 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/3b31797e_48f92f4c PS5, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/1ad7e4b8_347f908c PS5, Line 89: switch (access) { switch and case should be at the same indent
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/ffaba98a_f1359106 PS5, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/ee70bc3c_f3e844de PS5, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/ed0f7cf7_55bbf920 PS5, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159864): https://review.coreboot.org/c/coreboot/+/68137/comment/fd102c78_cbbf620a PS5, Line 34: switch (vpd) { switch and case should be at the same indent