Attention is currently required from: Arthur Heymans, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75611?usp=email )
Change subject: soc/amd/*/root_complex: reserve IOMMU MMIO area
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS2:
need to do this for the other socs too
Done
File src/soc/amd/common/block/include/amdblocks/iomap.h:
https://review.coreboot.org/c/coreboot/+/75611/comment/df15bad6_d63e0517 :
PS4, Line 15: 0xfd00000000
That's typically where the full SPI flash is mapped too right (ROM3 register)? […]
hmm, i'd need to have a closer look at this next week. somewhere at the beginning of the data fabric chapter the ppr says that most of this area is reserved for the iommu. there are 3 regions that cover more or less the full 4GB region, but might be that something else is in between those
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75611?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a8150873cb019ca1d903ed269e18d6f9fabb871
Gerrit-Change-Number: 75611
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 08 Jun 2023 15:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment